|
Kathey Marsden made changes - 09/Jan/09 07:58 PM
Kathey Marsden made changes - 09/Jan/09 08:00 PM
Kathey Marsden made changes - 09/Jan/09 08:00 PM
Hi Kathey. Looks good to me. I applied the patch and then ran the demoFileVtis.sql script. One thing I noticed is that the fixVersion elements are all concatenated, so the sample row that is selected by the apacheVanillaReport vti has a fixVersion field which looks like this: "10.2.2.110.3.1.410.4.0.0". You might want to think about how you want to handle that. Here are two suggestions:
1) Write a wrapper function that reformats that field for you. So you would write a query something like this: select myFormatter( s."fixVersion" ) from table( "apacheVanillaLogFile"( 'file:///opt/DerbyTrunk/java/demo/vtis/data/ApacheServerLog.xml' ) ) s 2) You could also change XmlVTI.parseRow() to do something other than just concatenate identically named child elements. E.g., insert a space between the text contents of those children. Thanks Rick for looking at the patch. I think option 2 sounds better. Do you think a space is most appropriate or would it be better to have a more distinguishable characters like ^ for separation?
Hi Kathey. Since you're actively using this vti, I think you should do what makes sense to you. Later on, for extra credit, we could change the XML vtis to take a second argument: the desired separator character. So the user would type a query like this:
select myFormatter( s."fixVersion", ' ' ) from table( "apacheVanillaLogFile"( 'file:///opt/DerbyTrunk/java/demo/vtis/data/ApacheServerLog.xml' ) ) s Attached is an updated patch for this issue. It has the same changes from the initial patch plus it:
- Changes XMLVTI.parseRow to separate multiple occurances of the same tag with spaces. - Changes derbyBuild/JiraConnector.java to take an optional all parameter to export all the issues. This is a bit out of the scope of this issue but will be useful for taking bug reports with the VTI. I will commit this tomorrow unless there are comments.
Kathey Marsden made changes - 13/Jan/09 12:38 AM
Kathey Marsden made changes - 13/Jan/09 04:52 PM
Myrna van Lunteren made changes - 04/May/09 06:22 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
"reporter", "assignee", "resolution", "created", "updated", "votes", "version", "fixVersion"
to the VTI