Issue Details (XML | Word | Printable)

Key: DERBY-3956
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Kristian Waagan
Reporter: Kristian Waagan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

Remove method TemplateRow.checkPartialColumnTypes

Created: 19/Nov/08 08:48 AM   Updated: 04/May/09 06:21 PM
Component/s: Store
Affects Version/s: 10.5.1.1
Fix Version/s: 10.5.1.1

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works derby-3956-1a.diff 2008-11-19 08:49 AM Kristian Waagan 3 kB

Resolution Date: 19/Nov/08 04:43 PM


 Description  « Hide
The method TemplateRow.checkPartialColumnTypes is only called from withing debug blocks, and it always return true.
I suggest the method is removed.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Kristian Waagan added a comment - 19/Nov/08 08:49 AM
Patch 1a deletes the method and removes all calls to it.
derbyall/suites.All ran cleanly (sane build).

Knut Anders Hatlen added a comment - 19/Nov/08 10:21 AM
The patch looks good to me. The alternative is to enable the check and
base it on checkColumnTypes(). But I'm fine with removing it since
it's of no value in its current shape.

Kristian Waagan added a comment - 19/Nov/08 04:43 PM
Committed patch 1b to trunk with revision 719008.

Thanks for looking at the patch, Knut Anders.