[#DERBY-3956] Remove method TemplateRow.checkPartialColumnTypes

Derby

Remove method TemplateRow.checkPartialColumnTypes

Created: 19/Nov/08 08:48 AM Updated: 04/May/09 06:21 PM

Component/s:

Store

Affects Version/s:

10.5.1.1

Fix Version/s:

10.5.1.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	derby-3956-1a.diff	2008-11-19 08:49 AM	Kristian Waagan	3 kB

Resolution Date:	19/Nov/08 04:43 PM
Labels:

Description

« Hide

The method TemplateRow.checkPartialColumnTypes is only called from withing debug blocks, and it always return true.
I suggest the method is removed.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Kristian Waagan made changes - 19/Nov/08 08:48 AM

Field	Original Value	New Value
Status	Open [ 1 ]	In Progress [ 3 ]

[ Permalink | « Hide ]

Kristian Waagan added a comment - 19/Nov/08 08:49 AM

Patch 1a deletes the method and removes all calls to it.
derbyall/suites.All ran cleanly (sane build).

Kristian Waagan made changes - 19/Nov/08 08:49 AM

Attachment

derby-3956-1a.diff [ 12394229 ]

[ Permalink | « Hide ]

Knut Anders Hatlen added a comment - 19/Nov/08 10:21 AM

The patch looks good to me. The alternative is to enable the check and
base it on checkColumnTypes(). But I'm fine with removing it since
it's of no value in its current shape.

Repository	Revision	Date	User	Message
ASF	#719008	Wed Nov 19 16:42:29 UTC 2008	kristwaa	~~DERBY-3956~~: Remove method TemplateRow.checkPartialColumnTypes Deleted the method, which always returned true and was only called from withing debug blocks (sane builds). Patch file: ~~DERBY-3956~~-1a.diff
				Files Changed
				MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/conglomerate/TemplateRow.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/btree/BTreeScan.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/btree/BTreeController.java

[ Permalink | « Hide ]

Kristian Waagan added a comment - 19/Nov/08 04:43 PM

Committed patch 1b to trunk with revision 719008.

Thanks for looking at the patch, Knut Anders.

Kristian Waagan made changes - 19/Nov/08 04:43 PM

Status	In Progress [ 3 ]	Resolved [ 5 ]
Derby Info	[Patch Available]
Resolution		Fixed [ 1 ]

Kristian Waagan made changes - 12/Jan/09 02:13 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Myrna van Lunteren made changes - 04/May/09 06:21 PM

Affects Version/s		10.5.1.1 [ 12313771 ]
Affects Version/s	10.5.0.0 [ 12313010 ]
Fix Version/s		10.5.1.1 [ 12313771 ]
Fix Version/s	10.5.0.0 [ 12313010 ]