Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-3956

Remove method TemplateRow.checkPartialColumnTypes

Details

    • Task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 10.5.1.1
    • 10.5.1.1
    • Store
    • None

    Description

      The method TemplateRow.checkPartialColumnTypes is only called from withing debug blocks, and it always return true.
      I suggest the method is removed.

      Attachments

        1. derby-3956-1a.diff
          3 kB
          Kristian Waagan

        Activity

          Committed patch 1b to trunk with revision 719008.

          Thanks for looking at the patch, Knut Anders.

          kristwaa Kristian Waagan added a comment - Committed patch 1b to trunk with revision 719008. Thanks for looking at the patch, Knut Anders.

          The patch looks good to me. The alternative is to enable the check and
          base it on checkColumnTypes(). But I'm fine with removing it since
          it's of no value in its current shape.

          knutanders Knut Anders Hatlen added a comment - The patch looks good to me. The alternative is to enable the check and base it on checkColumnTypes(). But I'm fine with removing it since it's of no value in its current shape.

          Patch 1a deletes the method and removes all calls to it.
          derbyall/suites.All ran cleanly (sane build).

          kristwaa Kristian Waagan added a comment - Patch 1a deletes the method and removes all calls to it. derbyall/suites.All ran cleanly (sane build).

          People

            kristwaa Kristian Waagan
            kristwaa Kristian Waagan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: