Issue Details (XML | Word | Printable)

Key: DERBY-3426
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Kathey Marsden
Reporter: Kathey Marsden
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby
DERBY-2653

Remove unused code for autogenerated keys columnNames

Created: 16/Feb/08 10:27 PM   Updated: 20/Feb/08 10:43 PM
Component/s: Network Client
Affects Version/s: 10.3.3.0, 10.4.1.3
Fix Version/s: 10.3.3.0, 10.4.1.3

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works derby-3426_diff.txt 2008-02-17 08:09 PM Kathey Marsden 8 kB
Text File Licensed for inclusion in ASF works derby-3426_diff2.txt 2008-02-18 12:14 AM Kathey Marsden 9 kB

Issue & fix info: Patch Available
Resolution Date: 18/Feb/08 03:20 PM


 Description  « Hide
There is unused code for autogenerated keys that processes columnNames by flowing a select from final table statement to the server. This syntax is not supported or used by Derby and should be removed from client.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Kathey Marsden added a comment - 17/Feb/08 08:09 PM
Attached is a patch to remove the unused code for autogenerated keys with columnNames. I ran suites.All and derbynetclientmats with jdk16.



Kathey Marsden added a comment - 17/Feb/08 09:40 PM
I found a problem with the derby-3426_diff.txt patch. Please ignore.

Kathey Marsden added a comment - 18/Feb/08 12:14 AM
Attached is derby-3426_diff2.txt which has the code removed. The original patch had a stray else left in the removed code. It is surprising it worked as well as it did #:) Ran suites.All and derbynetclientmats with the new patch.