[DERBY-336] The wrong overload of StandardException::newException() is used in some cases

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 10.1.2.1
• Fix Version/s: 10.2.1.6
• Environment: Any
• Assignee: Dyre Tjeldvoll
• Reporter: Dyre Tjeldvoll
• Created: 05/Jun/05 21:54
• Updated: 29/Jun/09 13:13
• Resolved: 11/Apr/06 01:43

Description

When looking at DERBY-128 it became clear that the wrong overload of StandardException::newException() was used when reporting
SQLState.SERVICE_DIRECTORY_CREATE_ERROR. The message string only takes one parameter so only one additional parameter (other than Throwable) should be used:

PersistentServiceImpl.java:676
throw StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR,
serviceDirectory, null);
// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Object)? Or StandardException.newException(String, Throwable, Object)? With the IOException as
// Throwable?

PersistentServiceImpl.java:692
throw StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR, name, t);
// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Throwable, Object)?

BaseDataFileFactory.java:279
throw StandardException.newException( SQLState.SERVICE_DIRECTORY_CREATE_ERROR, dataDirectory, ioe);

// Calls StandardException.newException(String, Object, Object)
// Should call StandardException.newException(String, Throwable, Object)?

Issue Links

• is related to: DERBY-128 Network Server Gives NPE if SQLException has null arguments (e.g. for ERROR XBM0H)