With 10.2, Closing a resultset after retrieving a large > 32665 bytes value with Network Server does not release locks

• Key: DERBY-2941
• Type: Sub-task
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Kathey Marsden
• Reporter: Kathey Marsden
• Component/s: Network Server
• Affects Version/s: 10.2.2.0
• Fix Version/s: 10.2.2.1, 10.3.1.4, 10.4.1.3

Description

Making a subtask for the 10.2 fix for this issue as the fix for 10.3 will be different.

Comments

[Kathey Marsden]

Attaching a patch for this issue. Patch only differs from patch attached to DERBY-2892 in that it has some corrections to javadoc.

-Changes EXTDTAInputStream to use ResultSet.getCharacterStream, ResultSet.getBinaryStream instead of getClob(), getBlob..

- Alters EngineResult for getLenth(int columnIndex) and isNull(int columnIndex) methods

-Enables LargeDataLocksTest

derbyall passed with only known failures.

I would most appreciate review. If I hear no objections I will commit tomorrow.

[Øystein Grøvlen]

I have looked at the patch, and I think the patch looks very good.
I only have some minor comments/questions:

 - Did you intend to leave the changes to DDMWriter in there?

 - You have added a comment that says "Stream is initialized on the
   first read". It is not quite clear to me what stream you are
   referring to. It looks to me that the caller has to initialize the
   stream (call initInputStream) BEFORE it is to be read.

 - There seem to be some indentation differences in the
   EXTDTAInputStream constructor.

 - I do not understand the javadoc for EXTDTAInputStream.isNUll. What
   do you mean by "determined in the constructor"? It seems like the
   only thing the constructor does is to register the parameter
   values.
  
+1 to commit, but would prefer that the comments discussed about is made clearer.

[Tomohito Nakayama]

I remember that I had trouble to retrieve length of stored data in DERBY-326.
http://mail-archives.apache.org/mod_mbox/db-derby-dev/200512.mbox/[e-mail]%3E

At that point, it seems that length information might be missing in some cases....

My understanding is that the engine was improved and
it became always possible to retrieve length of stored data via DataValueDescriptor#getLength().

[Kathey Marsden]

Fixed in 10.2 and ported to trunk and 10.3 and verified with 10.2 client. DERBY-2892 still needs to be fixed for server working with 10.3+ client

Kathey

[Myrna van Lunteren]

I know you checked in the test to 10.3 branch, but I'm doubting that this issue should be marked fixed for 10.3.1.2?

[Kathey Marsden]

I checked the fix into the 10.3 branch as well, so hopefully the fix version is ok. It only fixes 10.2 client with 10.3. It does not fix 2892 10.3 client with 10.3.

[Kathey Marsden]

Closing this issue for the fix with 10.2 and lower clients. The problem still exists with 10.3 clients which use the lob locator code path. DERBY-2892 remains open for that issue.