Authorization error codes have been moved. Translated messages must be moved accordingly.

• Key: DERBY-2633
• Type: Sub-task
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Jørgen Løland
• Reporter: Jørgen Løland
• Component/s: JDBC
• Affects Version/s: 10.3.1.4
• Fix Version/s: 10.3.1.4

Description

The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

Comments

[Jørgen Løland]

The patch (DERBY-1828-and-2633-1) contains patch 2indent of DERBY-1828 and the required changes to translated languages. Since only the error codes are changed, no translated messages have been deleted. They only have a new error code and a new location in the message_*.properties files.

[Jørgen Løland]

The patch (1) fails ProcedureInTriggerTest testTriggerNegative, which is a recurring error. I think this is unrelated. Apart from that, derbyall and suites.all runs cleanly.

[Jørgen Løland]

The patch (DERBY-2633-1) is stripped of modifications found in 1828-2indent. Use this patch if DERBY-1828 is committed standalone. The patch cannot be tested since the 1828 modifications are required.

[Knut Anders Hatlen]

I see this build failure after applying the DERBY-1828-and-2633-1.diff patch:

compile_jdbc4:
    [javac] Compiling 17 source files to /export/home/kh160127/derby/sandbox/1828+2633/classes
    [javac] /export/home/kh160127/derby/sandbox/1828+2633/java/client/org/apache/derby/client/am/SQLExceptionFactory40.java:75: cannot find symbol
    [javac] symbol : variable AUTHORIZATION_PREFIX
    [javac] location: interface org.apache.derby.shared.common.reference.SQLState
    [javac] } else if (sqlState.startsWith(SQLState.AUTHORIZATION_PREFIX)) {
    [javac] ^
    [javac] 1 error

BUILD FAILED

[Jørgen Løland]

I see now that I never used JDK 1.6, hence the build completed without errors. I will report back with a new patch once I have run the tests once more.

[Jørgen Løland]

The patch (DERBY-1828-and-2633-2) addresses the build error. Suites.All and derbyall runs cleanly except ProcedureInTriggerTest, which is a recurring error and likely unrelated.

The only difference from patch (1) is that AUTHORIZATION_PREFIX is replaced by AUTHORIZATION_SPEC_PREFIX in java/client/org/apache/derby/client/am/SQLExceptionFactory40.java

[Knut Anders Hatlen]

Thanks Jørgen! The patch looks good to me. I'll run the regression tests and commit.

[Knut Anders Hatlen]

Committed revision 537850.

[Jørgen Løland]

Thank you for reviewing and committing the patch, Knut