[#DERBY-2581] Callers of SanityManager.THROWASSERT should chain the exceptions when possible

Derby

Callers of SanityManager.THROWASSERT should chain the exceptions when possible

Created: 23/Apr/07 05:43 PM Updated: 25/Jul/08 05:30 PM

Return to search

Component/s:

Services, SQL

Affects Version/s:

10.3.1.4

Fix Version/s:

10.3.1.4

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
chain.diff	2007-04-23 05:53 PM	Knut Anders Hatlen	22 kB
chain.stat	2007-04-23 05:53 PM	Knut Anders Hatlen	2 kB

Resolution Date:

24/Apr/07 08:25 AM

Description

« Hide

Some places in the code where SanityManager.THROWASSERT is used to wrap unexpected exceptions, the underlying exception is not linked to the assert exception. Therefore, the original stack trace, and possibly the message text, are lost. THROWASSERT(Throwable) or THROWASSERT(String,THROWABLE) should be used instead in these cases.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Knut Anders Hatlen added a comment - 23/Apr/07 05:53 PM

The attached patch changes all the THROWASSERTs I found inside catch blocks so that the original exceptions are chained and preserved. Derbyall and suites.All passed.

[ Permlink | « Hide ]

Knut Anders Hatlen added a comment - 24/Apr/07 08:25 AM

Committed revision 531827.