Let BasePage.fetchFieldFromSlot use the special single-col FetchDescriptor ctor

• Key: DERBY-2223
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Dyre Tjeldvoll
• Reporter: Dyre Tjeldvoll
• Component/s: Miscellaneous
• Affects Version/s: 10.2.2.0
• Fix Version/s: 10.3.1.4

Description

BasePage.fetchFieldFromSlot needs to construct a FetchDescriptor with single column. To do this it creates a FormatableBitSet that identifies the correct column and then passes this bitset to the FetchDescriptor constructor. But FetchDescriptor has a special constructor for the single column case, that doesn't need a bitset. Using this constructor instead makes the code simpler, and presumably more efficient as well.

Comments

[Dyre Tjeldvoll]

Attached a patch for this. Junit tests and derbyall passes.

[Kristian Waagan]

Patch looks sound.
I'm starting a test run and will commit in a day or two if the test runs without errors.

[Kristian Waagan]

No errors seen in test run.
Patch 'derby-2223.v1.diff ' committed with revision 495159.