Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-2096

Change the Parser.parserStatement() to return the more specific StatementNode instead of QueryTreeNode.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 10.3.1.4
    • SQL
    • None

    Description

      Since this is compilinga statement returning the specific node makes more sense and will lead to a little more clarity in the code.
      Some of the methods defined on QueryTreeNode such as generate() and needsSavepoint() can move down to StatementNode and thus make the code more readable ("which generate is called for a value node?") and remove implementations of these methods that can never be called.

      Attachments

        Activity

          People

            djd Daniel John Debrunner
            djd Daniel John Debrunner
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: