[DBCP-470] Create a new BasicDataSource, the database hasn't start, the DBCP's pool will be leaked

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Information Provided
• Affects Version/s: 1.4
• Fix Version/s: 1.4.1
• Labels: robustness security

Environment

All environment

• Flags: Important
• Assignee: Unassigned
• Reporter: jeho0815
• Created: 25/Aug/16 02:14
• Updated: 30/Jan/23 23:44
• Resolved: 30/Jan/23 23:44

Description

First the database hasn't start, then create a new BasicDataSource. The method createDataSource judge dataSource == null, will create a new dataSource. The first step is create a connectionPool, second create a connectionFactory, but validateConnectionFactory will throw a SQLNestedException, the dataSource will be null again. Next itme repeat the steps again and again. The most import issue is create the connectionPool will be refered by a java.lang.Timer, so it can't be collected by GC. If the minIdle is positive, when database status is ok, it will create connection also.
As a word, the bug will cause memory leak and may cause connection leak.