[CONFIGURATION-786] ReloadingCombinedConfigurationBuilder needs to clear the reloadingController on resetParameters()

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.6
• Component/s: File reloading
• Assignee: Unassigned
• Reporter: David Citron
• Created: 18/Mar/20 21:29
• Updated: 18/Mar/20 22:13

Description

Modifying the configuration definition file causes CombinedConfigurationBuilder.resetParameters() to be called. This cleans up and clears the sourceData variable which causes the next invocation of initResultInstance() to create new child ConfigurationBuilder instances.

However, ReloadingCombinedConfigurationBuilder.reloadingController is not cleared (not set to null) and, as such, reloading stops working until a full restart.

I have worked around this by using reflection to set ReloadingCombinedConfigurationBuilder.reloadingController to null when resetParameters() is called, but perhaps further thought is required vis-a-vis a fix because re-creating the reloadingController  means that any attached PeriodicReloadingTrigger instances need to be shut down and re-created too (which is what I'm currently doing to make all this work).