[CONFIGURATION-641] XMLConfiguration.load may throw NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.1.1

Environment

Java 8 / Linux

• Assignee: Unassigned
• Reporter: Claude Warren
• Created: 19/Nov/16 23:40
• Updated: 22/Mar/17 09:12
• Resolved: 01/Dec/16 21:00

Description

I expect that

    URL url = Test.class.getResource( "/Test.xml");	
    XMLConfiguration config = new XMLConfiguration();
    config.read( url.openStream());

Would read the XML file. However it will throw a NPE at line 967

 private void load(InputSource source) throws ConfigurationException
    {
        try
        {
            URL sourceURL = locator.getSourceURL(); // <- NPE here
            if (sourceURL != null)
            {
                source.setSystemId(sourceURL.toString());
            }

I believe that testing for locator == null first will solve the problem as the rest of the code in the method does not appear to use it.