[COCOON-1589] ImageReader problem with grayScaleFilter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.7
• Component/s: - Components: Sitemap
• Environment: Operating System: Linux; Platform: PC
• Bugzilla Id: 36466
• Assignee: Unassigned
• Reporter: Vadim Bilan
• Created: 02/Sep/05 01:29
• Updated: 16/Feb/11 13:57
• Resolved: 14/Dec/05 20:28

Description

SiteMap:
<map:reader logger="sitemap.reader.image" name="jpg-reader"
src="org.apache.cocoon.reading.ImageReader"/>

<map:match pattern="**/*.jpg">
  <map:read type="jpg-reader" mime-type="image/jpg" src="image/{1}/{2}.jpg">
    <map:parameter name="expires" value="-1"/>
  </map:read>
</map:match>

I did not specify pool-max. The default value is set to 1, is it?
Becouse it always refers to the same instance

.../jpeg/image.jpg?widht=100
pipeline works fine until you specify parameter grayscale and set to true
.../jpeg/image.jpg?width=100&grayscale=true - works fine
but after that you can't create not grayscale image
.../jpeg/image.jpg?width=200&grayscale=false you will get grayscale image any
way, Because:
in Setup method you set this.grayscaleFilter

 if (par.getParameterAsBoolean("grayscale", GRAYSCALE_DEFAULT)) {
  this.grayscaleFilter = new
ColorConvertOp(ColorSpace.getInstance(ColorSpace.CS_GRAY), null);
  }

and never set to null, so when the pool of that ImageReader will be full of
instances with grayscaleFilter set it wont be possible to get original image