[CLK-744] Select control's setValue is not usable due to insufficient wrapping

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 2.3.0-M1, 2.2.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Sander van Grieken
• Created: 29/Dec/10 11:17
• Updated: 11/Jan/11 10:09
• Resolved: 29/Dec/10 21:11

Description

When calling setValue on a Select instance, it bombs out while rendering, regardless whether a String or an Option is passed.

Passing an Option instance causes it to be 'toString'-ed as an Object (i.e. 'org.apache.click.control.Option@1c154a3') when retrieving the selected value again.

Passing a String causes it to throw a java.lang.IllegalArgumentException: Select option class not instance of Option or OptionGroup: java.lang.String
at org.apache.click.control.Select.render(Select.java:998)

I have modified the render(HtmlStringBuffer buffer) method in Select.java to additionally check for String instances, and in that case wrap it into an Option, and that works fine.

if (object instanceof String)

{ Option option = new Option(object); option.render(this, buffer); }

else ...

The setValue method should probably be overridden from Field to also support the Option case