[CLI-6] Unknown options are ignored instead of throwing UnrecognizedOptionException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1
• Component/s: CLI-1.x
• Bugzilla Id: 17662
• Assignee: Unassigned
• Reporter: Peter Kunszt
• Created: 05/Mar/03 17:21
• Updated: 06/Feb/09 06:59
• Resolved: 24/Jul/08 23:18

Description

CLI does not handle unknown options, i.e. throw an 'UnrecognizedOptionException'.
The reason is that the logic of PosixParser.processOptionToken() is incomplete:

if (this.options.hasOption(token))

{ currentOption = this.options.getOption(token); tokens.add(token); }

else if (stopAtNonOption)

{ eatTheRest = true; }

ie. if the stopAtNonOption is not set and the token is unknown, it
will be ignored. there has to be a default case added:

else

{ tokens.add(token); }

in which case the caller will throw the proper exception, because
in Parse there is another check whether the option exists.

i would've submitted a patch but did not find where to, sorry.
peter