[cli] clone() method doesn't fully clone contents

• Key: CLI-56
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Rob Oxspring
• Component/s: CLI-1.x
• Affects Version/s: 1.0
• Fix Version/s: 1.1

Environment

Operating System: other
Platform: Other

Description

Broken out from #19749.

I'm a little weary of fixing this in case it was done this way on purpose... if
anyone cloning options would care to reasure me it would be appreciated. Also
need to decide if cli2 Options should be Cloneable

Rob

Comments

[Sebb]

The clone() method in CLI Option v 1.0 fails to clone the values array; this
means one can't pick up the values from options like "-D property=value"

Not sure whether the clone() method is really required - do options need to be
cloneable? Might be better to provide a copy constructor instead, and avoid all
the problems with clone.

[Henri Yandell]

clone() showed up in a commit from jkeyes, whose comment doesn't indicate any
reason for the addition:

http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli/Option.java?rev=129799&r1=129796&r2=129799

[Henri Yandell]

Removed clone() from Option - thus resolving this bug.