Issue Details (XML | Word | Printable)

Key: CLI-140
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Henning Schmiedehausen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Commons CLI

Make some CLI classes serializable

Created: 06/Aug/07 02:14 PM   Updated: 18/Nov/07 09:43 PM
Return to search
Component/s: CLI-1.x
Affects Version/s: 1.0, 1.1
Fix Version/s: 1.2

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works CLI-140_no_141.patch 2007-11-13 11:42 PM Bjorn Townsend 3 kB
Text File Licensed for inclusion in ASF works CLI-140_yes_141.patch 2007-11-13 11:42 PM Bjorn Townsend 2 kB

Resolution Date: 18/Nov/07 09:43 PM


 Description  « Hide
A number of CLI classes are serializable and could be used e.g. with RMI if only they would implement Serializable
  • Option.java
  • OptionGroup.java
  • CommandLine.java
  • Options.java


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Henri Yandell added a comment - 14/Aug/07 02:04 PM - edited
Consider for 1.2, especially if a patch shows up

Bjorn Townsend added a comment - 13/Nov/07 11:42 PM
Implemented serializable in the classes mentioned above. Note that Henning's patch to CLI-141 also implements Serializable in the Option class. Since I don't know which of these patches might be applied first, I've created two:

If you have already applied the patch for CLI-141, apply CLI-140_yes_141.patch.

If you have not already applied the patch for CLI-141, apply CLI-140_no_141.patch.


Brian Egge added a comment - 15/Nov/07 12:04 PM
I took a look at the CLI-140_no_141.patch, and I don't see any reason why it shouldn't be applied. I ran a clirr check, and the changes are backwards compatible.

INFO: 4000: org.apache.commons.cli.CommandLine: Added java.io.Serializable to the set of implemented interfaces
INFO: 4000: org.apache.commons.cli.Option: Added java.io.Serializable to the set of implemented interfaces
INFO: 4000: org.apache.commons.cli.OptionGroup: Added java.io.Serializable to the set of implemented interfaces
INFO: 4000: org.apache.commons.cli.Options: Added java.io.Serializable to the set of implemented interfaces


Henri Yandell added a comment - 18/Nov/07 09:43 PM
Applied 'yes' patch: 596142.