[CB-7658] generateTabletXMLFile shouldn't iterate config.configFileInjections unless it has elements

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: Master
• Component/s: cordova-blackberry (DEPRECATED)
• Assignee: Josh Soref
• Reporter: Josh Soref
• Created: 29/Sep/14 15:12
• Updated: 29/Sep/14 20:37
• Resolved: 29/Sep/14 20:37

Description

The current code checks to see if there's a non null, array, before iterating over config.configFileInjections, but...

function processResult(data, session) {
var widgetConfig = {};
...
//store any config-file element injections
widgetConfig.configFileInjections = _config_doc.findall("config-file");

return widgetConfig;

function generateTabletXMLFile(session, config) {
...
//Inject any config-file modifications for bar-descriptor.xml
if (config.configFileInjections && Array.isArray(config.configFileInjections)) {
xmlDoc = new et.ElementTree(et.XML(xmlData));
config.configFileInjections.forEach(function (config_file) {
if (config_file.attrib["parent"] && config_file.attrib["target"] && config_file.attrib["target"] === "bar-descriptor.xml") {
xmlHelper.graftXML(xmlDoc, config_file._children, config_file.attrib["parent"]);
}
});
xmlData = xmlDoc.write({indent: 4});
}