[CAUSEWAY-215] Change way that SQL objectstore determines the properties of an object to be persisted

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.2.0-incubating
• Fix Version/s: tidy-up
• Component/s: ZZZ Mothballed: Objectstore: SQL
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 13/Mar/12 23:05
• Updated: 11/Sep/15 14:21
• Resolved: 13/Mar/12 23:06

Description

Noticed that in some circumstances the database table that SQL object store attempts to create had duplicate column names. Tracked this behaviour down to the logic within org.apache.isis.runtimes.dflt.objectstores.sql.auto.AbstractAutoMapper - the setUpFieldMappers() method can be called into recursively, meaning that the simple aggregation of columns into a list (as then used by the setUpFullMapping method is not sufficient).

Although I don't understand everything that is going on here, it seems that a safer way to proceed is to use a Map and to key the elements by the ObjectAssociation (ie property); that way there can only ever be one "thing" added per processed field.