Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3472

Actually uses efficient cross DC writes

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Low
    • Resolution: Fixed
    • 0.8.8, 1.0.3
    • None
    • None
    • Low

    Description

      CASSANDRA-2138 introduced the following code:

      if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
      {
          // direct writes to local DC or old Cassadra versions
          for (InetAddress destination : messages.getValue())
              MessagingService.instance().sendRR(message, destination, handler);
      }
      else
      {
          // Non-local DC. First endpoint in list is the destination for this group
      

      A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for any version >= 0.7.1).

      A simple fix would be to add the missing !, but as said a comment, all this code should have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.

      Attachments

        1. 3472.patch
          3 kB
          Sylvain Lebresne

        Activity

          People

            slebresne Sylvain Lebresne
            slebresne Sylvain Lebresne
            Sylvain Lebresne
            Jonathan Ellis
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: