[CASSANDRA-18879] Modernize CQLSH datetime conversions

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 5.1-alpha1, 5.1
• Component/s: CQL/Interpreter
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/bfb5c593429c1bb615426ec2d35c1c27c7f81488

Test and Documentation Plan

Tested it manually.

My timezone is US/Eastern. You can see the tracing output showing the time (2024-01-16 16:18:43.599000-05:00) in my timezone and the table containing the time in UTC (2024-01-16 21:18:43.599000+0000).

(See attached log file)

• Assignee: Arun Ganesh
• Reporter: Brad Schoening

Authors

Arun Ganesh

Reviewers

Brad Schoening, Brandon Williams

• Created: 25/Sep/23 11:26
• Updated: 08/Mar/24 03:42
• Resolved: 06/Mar/24 15:48

Description

Python 3.x introduced many updates to datetime conversion which allows simplified conversions.

1. For example, tracing.py defines a function datetime_from_utc_to_local() but datetime now has a native function astimezone() which will convert UTC to local time.

Review the following users of datetime which apply conversions:

• cqlshmain.py
• formatting.py 
• tracing.py

Example: 

>>> from dateutil import tz
>>> import datetime
>>> a = datetime.datetime.now().astimezone(tz.tzutc())
>>> a
datetime.datetime(2023, 9, 25, 11, 22, 36, 251705, tzinfo=tzutc())
>>> b = a.astimezone()
>>> b
datetime.datetime(2023, 9, 25, 14, 22, 36, 251705, tzinfo=datetime.timezone(datetime.timedelta(seconds=10800), 'EST')) 

See [PEP 495]

 

Issue Links

• links to: GitHub Pull Request #2996