[CASSANDRA-18700] Remove AssertJ annotations from the production code

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.12, 4.1.4, 5.0-alpha1, 5.0
• Component/s: Build
• Bug Category: Code
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0.0

Source Control Link

https://github.com/apache/cassandra/commit/a0fdda1976c7de9e250e772ecddf6a7317cb1e37

Test and Documentation Plan

CI

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Brandon Williams

• Created: 27/Jul/23 11:06
• Updated: 12/Sep/23 13:03
• Resolved: 28/Jul/23 15:43

Description

We are using VisibleForTesting annotation from AssertJ in the production code. At the same time, we are not shipping assertj library in the tarball.

The way it works is that we depend on assertj with "provided" scope and then we will not ship the lib. It is possible, because the default RetentionPolicy for that annotation is CLASS which means that while we compile with the annotation, it does not need to be there in runtime ...

There is VisibleForTesting annotation from Guava which is used extensively. Usage of VisibleForTesting from AssertJ was used by mistake as that probably popped up as the first import to add when doing code completion in IDEA.

Issue Links

• blocks: CASSANDRA-17951 Update AssertJ
• links to: GitHub Pull Request #2524
• links to: GitHub Pull Request #2525
• links to: GitHub Pull Request #2526