[CASSANDRA-17617] CQLSH unicode control character list is too liberal

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.11.14, 4.0.5, 4.1-rc1, 4.1, 5.0-alpha1, 5.0
• Component/s: CQL/Interpreter
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/f884dda75b1427b8cb9aa64c46d30fb4c1eeffee

Test and Documentation Plan

See PR

• Assignee: Tanuj Nayak
• Reporter: Tanuj Nayak

Authors

Tanuj Nayak

Reviewers

Berenguer Blasi, Brandon Williams

• Created: 10/May/22 02:35
• Updated: 12/Sep/23 13:02
• Resolved: 14/Jun/22 05:04

Description

It appears that the list of escaped unicode control characters here is a bit too liberal. It seems to include characters such as '1' (0x31) and '0' (0x30) which do not need to be escaped. It seems that the actual range should be 0x00 - 0x1F and 0x7F+ as corroborated by this page.

 

This causes unnecessary escaping and regex substitutions on the CQLSH end whenever common characters such as any punctuation or a 0 or a 1 appear in the text column of a table. One might notice that a table with a text column filled with 2's will take much less time to print than one with all 0's for this reason.

Issue Links

• links to: CASSANDRA-17617 PR 1613