[CASSANDRA-14057] The size of a byte is not 2

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 3.0.16, 3.11.2
• Component/s: Legacy/Streaming and Messaging
• Severity: Low
• Assignee: Sylvain Lebresne
• Reporter: Sylvain Lebresne

Authors

Sylvain Lebresne

Reviewers

Jason Brown

• Created: 17/Nov/17 14:45
• Updated: 16/Apr/19 09:29
• Resolved: 18/Nov/17 13:19

Description

DataLimits serializer uses TypeSizes.sizeof((byte)limits.kind().ordinal()) in it's serializedSize method, but TypeSizes does not (on 3.0/3.11) have a sizeof(byte) override, so sizeof(short) is picked and it returns 2, which is wrong.

This is actually fixed on trunk, jasobrown committed the fix as part of CASSANDRA-8457, but it wasn't committed in 3.0/3.11 and that still feel dodgy to leave as is.

To be clear, I don't think it's a problem as of now: it does break the size computed for read commands, and thus the payload size of such message, but said payload size is not use (for read requests that is).

Still, not reason to leave something wrong like this and risk a future bug when the fix is trivial.