[CASSANDRA-12018] CDC follow-ups

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Assignee: Joshua McKenzie
• Reporter: Joshua McKenzie

Authors

Joshua McKenzie

Reviewers

Branimir Lambov

• Created: 16/Jun/16 19:43
• Updated: 16/Apr/19 09:30
• Resolved: 11/Jul/16 19:19

Description

Platform independent implementation of DirectorySizeCalculator

On linux, simplify to Arrays.stream(path.listFiles()).mapToLong(File::length).sum();

Refactor DirectorySizeCalculator

I don't get the DirectorySizeCalculator. Why the alive and visited sets, the listFiles step? Either list the files and just loop through them, or do the walkFileTree operation – you are now doing the same work twice. Use a plain long instead of the atomic as the class is still thread-unsafe.

TolerateErrorsInSection should not depend on previous SyncSegment status in CommitLogReader

tolerateErrorsInSection &=: I don't think it was intended for the value to depend on previous iterations.

Refactor interface of SImpleCachedBufferPool

SimpleCachedBufferPool should provide getThreadLocalReusableBuffer(int size) which should automatically reallocate if the available size is less, and not expose a setter at all.

Change CDC exception to WriteFailureException instead of WriteTimeoutException

Remove unused CommitLogTest.testRecovery(byte[] logData)

NoSpamLogger a message when at CDC capacity

Issue Links

• relates to: CASSANDRA-8844 Change Data Capture (CDC)