[CALCITE-6263] Discuss the coupling of Calcite with JTS

• Type: New Feature
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: jdbc-adapter
• Assignee: Unassigned
• Reporter: Bertil Chapuis
• Created: 14/Feb/24 08:50
• Updated: 05/Mar/24 01:39

Description

In order to push ST functions down to Postgis in the JDBC adapter, it is necessary to register a type family for geometries in RelDataTypeFactoryImpl.java. This changes increases the coupling of Calcite to a geometry library such as JTS.

As this is an architectural change, a few options can be considered:

1. Accepting the coupling of Calcite with JTS.
2. Introducing an abstraction for geometry libraries in Calcite.
3. Using reflection to register the type family only if JTS is available in the classpath.

Personally, I have a preference for options 1 and 3. Option 3, which is currently implemented in CALCITE-6239 has little impact on the current behavior. Option 2 would introduce some additional complexity.

For context, here is a link to the original discussion.

 

 

Issue Links

• relates to: CALCITE-6239 Add a PostGIS dialect that supports ST_ functions