[CALCITE-5340] Tests should fail when actual and expected XML reference files are not identical

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.32.0
• Fix Version/s: 1.33.0
• Component/s: build, tests
• Labels: pull-request-available
• Assignee: Alessandro Solimando
• Reporter: Alessandro Solimando
• Created: 21/Oct/22 08:40
• Updated: 07/Feb/23 22:33
• Resolved: 26/Oct/22 10:23

Description

Calcite has several XML reference files for tests.

When a new test is added, those files should be updated by copying the new, automatically-generated, version.

Sometimes the files are updated manually, and differ from the automatic generation, which makes it harder for the next developer to rely on automatic generation.

Following the discussion in the ML, it is desirable to have tests failing upon discrepancies.

This ticket aims at tracking the effort towards this goal.

DiffRepository class is responsible for diffing, so it's the first candidate to consider for adding such a check.

Issue Links

• causes: CALCITE-5501 SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in Jenkins CI
• links to: GitHub Pull Request #2948