[CALCITE-5270] JDBC adapter should not generate FILTER (WHERE) in Firebolt dialect

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.31.0
• Fix Version/s: 1.32.0
• Component/s: jdbc-adapter
• Labels: pull-request-available
• Assignee: TJ Banghart
• Reporter: TJ Banghart
• Created: 06/Sep/22 23:30
• Updated: 10/Sep/22 08:40
• Resolved: 09/Sep/22 06:39

Description

JDBC adapter should not generate FILTER (WHERE) in the Firebolt dialect, because Firebolt does not support filter clauses in aggregate functions. For example, COUNT(*) FILTER (WHERE a = 2)  throws 

Invalid operation error: SQL query not valid.
SQL query:
==========
SELECT COUNT FILTER (WHERE a = 2) FROM <table>
                    ^=== ERROR HERE!
==========
 

The fix is for supportsAggregateFunctionFilter to return false. The dialect implementation should override the supportsAggregateFunctionFilter method it currently inherits from the  base SqlDialect class.

See Firebolt SQL reference.

Issue Links

• is related to: CALCITE-4321 JDBC adapter omits FILTER (WHERE ...) expressions when generating SQL
• links to: GitHub Pull Request #2896