[CALCITE-4576] Release process should not overwrite LICENSE file

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: avatica-1.17.0, 1.26.0
• Fix Version/s: avatica-1.18.0, 1.27.0
• Component/s: avatica, build
• Assignee: Julian Hyde
• Reporter: Julian Hyde
• Created: 09/Apr/21 21:25
• Updated: 18/May/21 11:23
• Resolved: 12/May/21 04:48

Description

The release process should not generate a source distribution whose LICENSE file has different contents from the LICENSE file stored in Git.

Rationale: Source distributions should be a mirror of the contents of Git at the time of the release. (Possibly a few files are omitted – see CALCITE-4575 for example – but files should not be generated/compiled.) Users expect that the LICENSE file they see in Git is the same as the LICENSE file in the source distribution.

One possible implementation of this is as follows. The release process should not overwrite the LICENSE file when generating the source distribution. It should generate a LICENSE file (possibly from a LICENSE.template file), check that the one in source control is identical, and fail if it is not.

Issue Links

• links to: PR 144