[CALCITE-3249] Substitution#getRexShuttle does not consider RexLiteral

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.21.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Jin Xing
• Reporter: Jin Xing
• Created: 14/Aug/19 08:21
• Updated: 10/Sep/19 21:37
• Resolved: 16/Aug/19 21:21

Description

Current Substitution#getRexShuttle does not take RexLiteral into consideration.
Thus below query & mv fails matching:

MV:
select deptno, sum(salary), sum(commission), sum(k)
from
  (select deptno, salary, commission, 100 as k
  from emps)
group by deptno

Query:
select deptno, sum(salary), sum(k)
from
  (select deptno, salary, 100 as k
  from emps)
group by deptno

The root cause is that ProjectToProjectUnifyRule compensates a Project which contains RexLiteral, but AggregateOnProjectToAggregateUnifyRule works only when the Project in query is a mapping
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java#L1357

Issue Links

• links to: GitHub Pull Request #1377