[CALCITE-1482] Resource leak on creation of CassandraSchema

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.11.0
• Component/s: cassandra-adapter
• Assignee: Michael Mior
• Reporter: Michael Mior
• Created: 03/Nov/16 18:08
• Updated: 06/Jan/17 19:30
• Resolved: 04/Nov/16 18:36

Description

Found via the following Coverity scan

*** CID 138163:  Resource leaks  (RESOURCE_LEAK)
/cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java: 115 in org.apache.calcite.adapter.cassandra.CassandraSchema.<init>(java.lang.String, java.lang.String, java.lang.String, java.lang.String, org.apache.calcite.schema.SchemaPlus, java.lang.String)()
109         } catch (Exception e) {
110           throw new RuntimeException(e);
111         }
112         this.parentSchema = parentSchema;
113         this.name  = name;
114
>>    CID 138163:  Resource leaks  (RESOURCE_LEAK)
>>    Ignoring resource created by "org.apache.calcite.runtime.Hook.TRIMMED.add(this.new org.apache.calcite.adapter.cassandra.CassandraSchema.1())" leaks it.
115         Hook.TRIMMED.add(new Function<RelNode, Void>() {
116           public Void apply(RelNode node) {
117             CassandraSchema.this.addMaterializedViews();
118             return null;
119           }
120         });