[BIGTOP-4105] Build fails when '-DpkgSuffix' is specified and '(rpm|deb)_pkg_suffix' is not specified in bigtop.bom

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: build
• Assignee: Mathew Kapkiai
• Reporter: Mathew Kapkiai
• Created: 11/May/24 17:52
• Updated: 14/May/24 06:07
• Resolved: 14/May/24 06:07

Description

Build fails when '-DpkgSuffix' is specified when '(rpm|deb)_pkg_suffix'  is not specified in bigtop.bom

Issue introduced this bug by not checking whether the '(rpm|deb)_pkg_suffix' has been specified in bigtop.bom.

When config '(rpm|deb)_pkg_suffix'  is not specified, groovy returns an empty map  '[:]' which breaks the build. 

 

 

Task :bigtop-groovy-srpm
Wrote: /home/mathew/Projects/bigtop/build/bigtop-groovy/rpm/SRPMS/bigtop-groovy-2.5.4-1.el8.src.rpm> Task :bigtop-utils-srpm
Wrote: /home/mathew/Projects/bigtop/build/bigtop-utils/rpm/SRPMS/bigtop-utils-3.3.0-1.el8.src.rpm> Task :bigtop-utils-rpm FAILED
error: cannot open /home/mathew/Projects/bigtop/output/bigtop-utils/bigtop-utils[:]-3.3.0-1.el8.src.rpm: No such file or directoryFAILURE: Build failed with an exception.
 

 

Sample code to illustrate the source of bug. Below groovy sample is how packages.gradle access project config in bigtop.bom

def bom = """bigtop {
    name = "ambari"
}"""

def conf = new ConfigSlurper().parse(bom)

println('Output')
println(conf.bigtop.name)
println(conf.bigtop.not_exist) 

// Output
// ambari
// [:]

 

 

Issue Links

• links to: GitHub pull request #1268