Uploaded image for project: 'Beehive'
  1. Beehive
  2. BEEHIVE-1083

netui leaks PageFlowContext object attached to ThreadLocal

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • 1.0.1
    • 1.0.2
    • NetUI
    • None

    Description

      In the PageFlowRequestProcessor and PageFlowPageFilter, a NetUI ThreadLocal of type PageFlowContext is attached to the thread, but since it's never unattached, it's leaked into the thread pool. In Tomcat where threads are generally servicing web related requests (NetUI ones where there's only one webapp deployed), this doesn't surface as an issue.

      But, in a broader container, this reference holds onto aServletRequest, ServletResponse, and ServletContext object which can cause problems when a server handles broader requests over a longer period of time.

      Seems that there are two options:
      1) removing the PageFlowContext from the thread local entirely
      2) removing the PageFlowContext from the thread local at the end of the servlet / filter

      I'm leaning toward (1) because the thread local is only used inside of the simple tags that were added in October but haven't really shipped yet.

      Attachments

        Activity

          People

            ekoneil Edward O'Neil
            ekoneil Edward O'Neil
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: