Issue Details (XML | Word | Printable)

Key: BEEHIVE-1068
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Julie Zhuo
Reporter: Eddie O'Neil
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Beehive

requests to a JPF in a webapp without a Global.app throws two CNF exceptions

Created: 16/Feb/06 11:32 AM   Updated: 28/Feb/06 05:20 AM
Return to search
Component/s: NetUI
Affects Version/s: 1.0.2
Fix Version/s: 1.0.2

Time Tracking:
Not Specified

Resolution Date: 28/Feb/06 05:20 AM


 Description  « Hide
In doing some performance profiling, I've run into a place in the Page Flow core code that throws a ClassNotFoundException when a web application doesn't contain a global/Global.java source file. When forwarding to a JSP, this CNF exception happens twice.

This has a significant impact on performance and is marked as a "blocker" bug. The fix requires caching a flag that says whether the web application contains a global.Global class file, and short-circuiting its construction if the web application doesn't have this class file.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #378296 Thu Feb 16 16:45:35 UTC 2006 ekoneil Fix for BEEHIVE-1068. This change alters the behavior of the method that looks up a "global/Global.class" object for back-compat. If the check fails once, a ServletContext attribute is set in FlowControllerFactory that prevents the lookup from running again. This short-circuits the logic that throws a ClassNotFoundException twice on a simple JPF -> JSP request.

The distribution tests and BVTs both passed with this change.

BB: self
Tests: see above
Files Changed
MODIFY /beehive/trunk/netui/src/pageflow/org/apache/beehive/netui/pageflow/FlowControllerFactory.java