[BEANUTILS-283] ConvertUtilsBean doesn't handl conversion to String correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 1.8.0
• Component/s: ConvertUtils & Converters

Environment

commons-beanutils-20070610-src.zip

• Assignee: Niall Pemberton
• Reporter: Josef Cacek
• Created: 11/Jun/07 13:50
• Updated: 25/Mar/08 08:08
• Resolved: 11/Jun/07 15:50

Description

Either lookup(Class, Class) or convert(Object, Class) method doesn't work correctly in class ConvertUtilsBean.
Problematic is the case when target class is String.

The code from convert(..) which doesn't work:

Object converted = value;
Converter converter = lookup(sourceType, targetType);
if (converter != null) {
if (log.isTraceEnabled())

{ log.trace(" Using converter " + converter); }

converted = converter.convert(targetType, value);
}
// here we already have converted value (String), but we will rewrite it by default .toString() - it's a bug
if (targetType == String.class && value != null)

{ converted = value.toString(); }