[BEAM-3416] File is not properly closed in VcfSource when exception is thrown

• Type: Bug
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: sdk-py-core
• Assignee: Asha Rostamianfar
• Reporter: Asha Rostamianfar
• Created: 05/Jan/18 16:29
• Updated: 16/May/20 13:22
• Resolved: 25/Jan/18 16:54

Description

Files are not properly closed when an exception is thrown in VcfSource (apache_beam/io/vcfio.py).
This is because the file is opened within TextSource (using a 'with' statement), but the exception in VcfSource is thrown outside of that scope.

This only causes an issue in Windows unit tests where files cannot be deleted if they're used by another process.

Issue Links

• links to: GitHub Pull Request #4349