Remove ssl options from WSDL2Ws

• Key: AXISCPP-267
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: John Hawkins
• Component/s: WSDL processing - RPC
• Affects Version/s: 1.4 Alpha

Description

WSDL2Ws has two ssl options which are now out of date and not used -
In the Call class we have:
int AXISCALL initialize(PROVIDERTYPE nStyle, int secure);
and
int openConnection(int secure);

The secure parameters in these methods are not used at all. Ideally they have to be removed from
the code to avoid confusion. The WSDL tool option must have been based on these parameters.

Thanks,
Samisa...

--- Samisa Abeysinghe <[e-mail]> wrote:

> I have seen this secure option in the code and I think they are no more operational.
>
> There was an effort for SLL implementation in 1.0 (and may be in 1.1) and this option was for
> that. But later this was deprecated by the new transport astract layer desing and this option is
> no more valid with the new transport desing we have.
>
> As the latest efforts on SSL support is independent of the generated code (which is the correct
> way to support channel security) I think we can very safely get rid of this WSDL2Ws tool option.
>
> Thanks,
> Samisa...
>
> --- John Hawkins <[e-mail]> wrote:
>
> >
> >
> >
> >
> > Hi, does anyone know where these came from or what they do?
> >
> >
> > John Hawkins
> >
> >
> >
> >
> >
> > John
> > Hawkins/UK/IBM@IB
> > MGB To
> > [e-mail]
> > 16/11/2004 13:32 cc
> >
> > Subject
> > Please respond to SSL WSDL2Ws options
> > "Apache AXIS C
> > Developers List"
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Hi Folks,
> > there are some options on WSDL2ws for ssl ->
> >
> > -c<none|ssl> channel security (ssl|none) - default is none
> >
> > What do they do? Why does a user have to decide at this time whether their
> > service is securty enabled or not? Sounds wrong to me?
> >
> > cheers,
> > John.
> >
> > John Hawkins

Comments

[John Hawkins]

I've removed the WSDL2Ws option. However, WSDL2Ws creates the stub and, of course, the stub has calls to SSL functionality.

I did not want to alter the engine (especially SSL!) just prior to 1.4 release. So I've left the stub calling "NORMAL_CHANNEL" - these calls need to be removed. in the ClientStubWriters
when writing the following call ->
AXIS_SUCCESS != pCall->_functions->initialize(pCall->_object,

To do this, obviously, the engine API needs to change.

[Samisa Abeysinghe]

John!
    Shall we do the engine API changes you have proposed in 1.5?
Samisa...

[John Hawkins]

That was my perspective - particularly given the current SSL discussions. Doing it now would just cause yet more confusion :-)

[John Hawkins]

Fixed.