Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
1.6 Beta
-
None
Description
The assignment operators for SoapFaultException and OtherFaultException causes warning messages to be issued on some platforms, causes an addition copy to be made for the object to be copied, and has the virtual keyword specified which is unneccessary. So the methods have been changed from:
virtual SoapFaultException& operator=(SoapFaultException other);
virtual OtherFaultException& operator=(OtherFaultException other);
TO:
SoapFaultException& operator=(const SoapFaultException& other);
OtherFaultException& operator=(const OtherFaultException& other);
Forgot to mention that this is due in part to Haiping Zhao many changes posted on the mailing list, which I am going through slowly. Doing the easy stuff first.
Thanks Haiping!