[AVRO-3953] C# CodeGen.cs:503 incorrectly throws for "reserved keywords"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.3
• Fix Version/s: 1.12.0
• Component/s: csharp
• Labels: pull-request-available

Environment

Any use of the C# generator with enums that contain reserved keywords

• Assignee: Zoltan Csizmadia
• Reporter: Clemens Vasters
• Created: 04/Mar/24 09:44
• Updated: 13/Mar/24 07:39
• Resolved: 06/Mar/24 16:32

Description

The C# CodeGen.cs incorrectly chooses to throw when it encounters a C# reserved keyword as an enum member. 

In C#, any identifier that clashes with a reserved keyword can be escaped with a leading '@', e.g. this works:

enum Foo

{     @string = 1,     @int = 2,     @float = 3 }

This is a pretty serious issue with any Avro schema that describes programming-related structures. 

Issue Links

• links to: GitHub Pull Request #2783