Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-3203

Fix the Ruby distribution build to work

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently, building the Ruby distribution in the Docker container fails as follows.

      $ ./build.sh docker
      $ cd lang/ruby 
      $ ./build.sh clean dist
      
      ...
      
      rake aborted!
      ArgumentError: wrong number of arguments (given 2, expected 0)
      /home/sekikn/avro/lang/ruby/.gem/gems/echoe-4.6.6/lib/echoe/rubygems.rb:10:in `validate'
      /home/sekikn/avro/lang/ruby/.gem/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
      Tasks: TOP => dist => gem => pkg/avro-1.11.0.pre1.gem
      (See full trace by running task with --trace)
      

      This is because Ruby 2.7 is used in the Docker container and its rubygems library version is 3.1.2.
      rubygems have changed the semantics of its validate function from v3.x, and echoe doesn't seem to be compatible with that change.

      We should replace echoe with something simliar since it has not been maintained for several years, but it looks a bit tough to me, so I propose an easy workaround that building gem with the gem build command directly instead of via bundler, and using echoe only to generate avro.gemspec.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sekikn Kengo Seki
            sekikn Kengo Seki
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m

                Slack

                  Issue deployment