[AVRO-2923] GenericDatum::logicalType() API should return the logical type corresponing to one of the constituent types of the union

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Fix Version/s: 1.11.0
• Component/s: c++
• Labels: pull-request-available
• Assignee: Yang Xu
• Reporter: Yang Xu
• Created: 20/Aug/20 01:08
• Updated: 26/Aug/21 14:35
• Resolved: 26/Aug/21 14:35

Description

According to the avro document, GenericDatum::logicalType() API should behave Just like GenericDatum::type() or GenericDatum::value() APIs to return the logical type corresponing to one of the constituent types of the union When it was a Union type.

inline Type GenericDatum::type() const {
    return (type_ == AVRO_UNION) ?
#if __cplusplus >= 201703L
        std::any_cast<GenericUnion>(&value_)->datum().type() :
#else
        boost::any_cast<GenericUnion>(&value_)->datum().type() :
#endif
        type_;
}

template<typename T> T& GenericDatum::value() {
    return (type_ == AVRO_UNION) ?
#if __cplusplus >= 201703L
        std::any_cast<GenericUnion>(&value_)->datum().value<T>() :
        *std::any_cast<T>(&value_);
#else
        boost::any_cast<GenericUnion>(&value_)->datum().value<T>() :
        *boost::any_cast<T>(&value_);
#endif
}

while logicalType api was like this:

inline LogicalType GenericDatum::logicalType() const {
    return logicalType_;
}

it should also do the GenericUnion check

Issue Links

• links to: GitHub Pull Request #949
• links to: GitHub Pull Request #949