[AVRO-2722] impl/DataFile.cc use of boost::mt19937 for DataFileWriteBase::makeSync is not thread safe

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 1.11.1, 1.12.0
• Component/s: c++
• Labels: pull-request-available

Environment

Issue can be reproduced in Linux with clang and on Android arm64 and armeabi with android NDK r19c.

• Assignee: Martin Tzvetanov Grigorov
• Reporter: Dan Schmitt
• Created: 29/Jan/20 21:11
• Updated: 05/Jan/22 12:48
• Resolved: 05/Jan/22 12:30

Description

The single instance of random is not thread safe, and can seg fault.

It can be fixed with a global std::mutex next to the global boost::mt19937 generator and a std::unique_lock in the method, or by creating the mersenne_twister_engine as a local variable in the function.

Issue Links

• links to: GitHub Pull Request #1365