[AVRO-2026] Incorporate valgrind memory testing for C

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Component/s: c
• Assignee: John Gill
• Reporter: John Gill
• Created: 16/Apr/17 05:59
• Updated: 07/Feb/20 10:16
• Resolved: 10/Dec/18 19:20

Description

With the work done for AVRO-1167 & AVRO-766 in identifying memory leaks decided to make it a standard part of the testing framework. This issue requires https://github.com/apache/avro/pull/218 otherwise test_avro_schema and test_avro_values fail due to to avro_schema_copy calls.

Adding valgrind tool to the docker container
Adding valgrind to CMakeLists.txt to optionally do valgrind testing if the tool is found
Cleaning up existing tests that were failing due to not properly cleaning up memory
Lastly, as part of ./build.sh test for lang/c do not remove the build/c directory. The memcheck output is kept so that memory leak issues can be reviewed and addressed.

Issue Links

• links to: GitHub Pull Request #218