Uploaded image for project: 'Atlas'
  1. Atlas
  2. ATLAS-2805

Update Classification: Does Not Update modificationTimestamp

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.8.3
    • 0.8.3, 1.2.0, 2.0.0
    • atlas-core
    • None

    Description

      Background

      Existing implementation of EntityGraphMapper.addClassifications does not update modificationTimestamp

      This causes inconsistency if entities are fetched using modificationTimestamp

      Steps to Duplicate

      Pre-requisites: Setup an instance with few entities. Create classifications, say PII. Do not associate any entity with classification.

      Steps:

      1. Search an entity and display it in web UI. Note the modificationTimestamp.
      2. Associate the entity above with PII classification.
      3. Refresh the web page. Notice that the  modificationTimestamp is unchanged.

      Approach Guidance

      • EntityGraphMapper should have 2 public methods that explicitly state their purpose. Say addClassifications and addClassificationWIthNoMetadataUpdate.
      • The addClassifications will update the modificationTimestamp, the other will not.
      • RequestContextV1 should be updated to have a request the ability to update or not update timestamp. This should be checked in the method: updateModificationMetadata.

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            amestry Ashutosh Mestry
            amestry Ashutosh Mestry
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment