[ATLAS-1912] Coverity issue in AtlasRelationshipDefStoreV1

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Assignee: David Radley
• Reporter: David Radley
• Created: 03/Jul/17 14:47
• Updated: 12/Apr/18 20:15
• Resolved: 12/Apr/18 20:15

Description

• • CID 164823: Null pointer dereferences (NULL_RETURNS)
    /repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java: 88 in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1.preCreate(org.apache.atlas.model.typedef.AtlasRelationshipDef)()

________________________________________________________________________________________________________

• • • CID 164823: Null pointer dereferences (NULL_RETURNS)
      /repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java: 88 in org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1.preCreate(org.apache.atlas.model.typedef.AtlasRelationshipDef)()
      82 final String type1 = endDef1.getType();
      83 final AtlasRelationshipEndDef endDef2 = relationshipDef.getEndDef2();
      84 final String type2 = endDef2.getType();
      85 final String name1 = endDef1.getName();
      86 final String name2 = endDef2.getName();
      87
      >>> CID 164823: Null pointer dereferences (NULL_RETURNS)
      >>> Assigning: "end1TypeVertex" = null return value from "findTypeVertexByName".
      88 AtlasVertex end1TypeVertex = typeDefStore.findTypeVertexByName(type1);
      89
      90 AtlasVertex end2TypeVertex = typeDefStore.findTypeVertexByName(type2);
      91 // create an edge between the relationshipDef and each of the entityDef vertices.
      92 AtlasEdge edge1 = typeDefStore.getOrCreateEdge(relationshipDefVertex, end1TypeVertex, AtlasGraphUtilsV1.RELATIONSHIPTYPE_EDGE_LABEL);