[ARROW-5036] [Plasma][C++] Serialization tests resort to memcpy to check equality

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: C++ - Plasma
• External issue URL: https://github.com/apache/arrow/issues/21531
• Assignee: Unassigned
• Reporter: Francois Saint-Jacques
• Created: 27/Mar/19 16:21
• Updated: 11/Jan/23 07:37
• Resolved: 18/Sep/19 13:27

Description

1: /tmp/arrow-0.13.0.Q4czW/apache-arrow-0.13.0/cpp/src/plasma/test/serialization_tests.cc:193: Failure
1: Expected equality of these values:
1:   memcmp(&plasma_objects[object_ids[0]], &plasma_objects_return[0], sizeof(PlasmaObject))
1:     Which is: 45
1:   0
1: [  FAILED  ] PlasmaSerialization.GetReply (0 ms)

The source of the problem is the random_plasma_object stack allocated object. As a fix, I propose that PlasmaObject implements the `operator==` method and drops the memcpy equality check.

Issue Links

• duplicates: ARROW-5194 [C++][Plasma] TEST(PlasmaSerialization, GetReply) is failing