[ARROW-4520] [C++] DCHECK custom messages are unreachable in release

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/15968
• Assignee: Ben Kietzman
• Reporter: Ben Kietzman
• Created: 09/Feb/19 03:08
• Updated: 11/Jan/23 07:34
• Resolved: 26/Mar/19 22:13

Description

For release builds, DCHECK( x ) << y << z; currently expands to

((void)(x)); 
while (false) ::arrow::util::ArrowLogBase() << y << z;

This is unreachable which is an error using clang-7

Issue Links

• is related to: ARROW-5088 [C++] Do not set -Werror when using BUILD_WARNING_LEVEL=CHECKIN in release mode
• links to: GitHub Pull Request #3599
• links to: GitHub Pull Request #4027