[AMQ-6042] In ActiveMQMessageConsumer, always set rollback cause

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.13.0
• Component/s: Broker
• Assignee: Unassigned
• Reporter: Martin Lichtin
• Created: 13/Nov/15 09:20
• Updated: 30/Nov/15 19:01
• Resolved: 20/Nov/15 21:19

Description

In ActiveMQMessageConsumer, currently the rollback cause is only set for the case auto- or individual-acks. However, it should also be set for the other cases, so that in the rollback() method it can be picked up when creating the poison ack.

    if (isAutoAcknowledgeBatch() || isAutoAcknowledgeEach() || session.isIndividualAcknowledge()) {
        // schedual redelivery and possible dlq processing
        md.setRollbackCause(e);
        rollback();
    } else {
        // Transacted or Client ack: Deliver the next message.
        afterMessageIsConsumed(md, false);
    }

I'd suggest to move md.setRollbackCause(e); to before the if().

Issue Links

• is related to: AMQNET-513 Exception message is not propagated in case of consumption failure
• is related to: AMQCPP-588 Always set a rollback cause on exception thrown in onMessage