[AMQ-1618] Improper handling of container restrictions in creation of sessions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.1, 5.0.0
• Fix Version/s: 5.1.0
• Component/s: Connector, Geronimo Integration

Environment

All

• Assignee: David Jencks
• Reporter: Manu T George
• Created: 12/Mar/08 10:44
• Updated: 22/Apr/08 17:21
• Resolved: 14/Mar/08 20:23

Description

In the getServerSession() method of org.apache.activemq.ra.ServerSessionPoolImpl there is an issue with the code block given below

ServerSessionImpl ss = createServerSessionImpl();
// We may not be able to create a session due to the container
// restricting us.
if (ss == null) {
if (idleSessions.size() == 0)

{ throw new JMSException("Endpoint factory did not allows to any endpoints."); }

return getExistingServerSession();
}

If the container restricts the creation of a session then messages should be queued to an existing session. So the check should be

if (activeSessions.size() == 0) { throw new JMSException("Endpoint factory did not allows to any endpoints."); }

instead of the one above