[AMBARI-25293] Logsearch: logfeeder throws NPE when updating checkpoint

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.3
• Fix Version/s: 2.7.4
• Component/s: logsearch
• Labels: pull-request-available
• Assignee: Krisztian Kasa
• Reporter: Krisztian Kasa
• Created: 04/Jun/19 12:04
• Updated: 05/Jun/19 04:59
• Resolved: 05/Jun/19 04:59

Description

Every time when logfeeder sends a log entry to solr it updates the corresponding checkpoint file. After a log file rolled over every subsequent checkpoint file update fails with NPE

2019-06-04 00:00:13,611 [OutputSolr,audit_logs,worker=0] ERROR org.apache.ambari.logfeeder.util.LogFeederUtil (LogFeederUtil.java:134) - Caught exception checkIn. , input=input:source=file, path=/var/log/hadoop/hdfs/hdfs-audit.log
java.lang.NullPointerException
        at org.apache.ambari.logfeeder.input.file.FileCheckInHelper.checkIn(FileCheckInHelper.java:45)
        at org.apache.ambari.logfeeder.input.InputFile.checkIn(InputFile.java:147)
        at org.apache.ambari.logfeeder.input.InputFile.checkIn(InputFile.java:49)
        at org.apache.ambari.logfeeder.output.OutputSolr$SolrWorkerThread.addToSolr(OutputSolr.java:472)
        at org.apache.ambari.logfeeder.output.OutputSolr$SolrWorkerThread.sendToSolr(OutputSolr.java:380)
        at org.apache.ambari.logfeeder.output.OutputSolr$SolrWorkerThread.run(OutputSolr.java:340)

There is no entry in the map returned by inputFile.getCheckPointFiles() with the new file key
https://github.com/apache/ambari/blob/fd3024cc2d7e8493446ccf42e81ed52497379cce/ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/file/FileCheckInHelper.java#L43

Issue Links

• links to: GitHub Pull Request #2998